Avoid altering score on write #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good -- there was one additional deepcopy still there. Just patched it up. Will merge (or @jacobtylerwalls can) if I didn't introduce any lint errors/bugs. |
|
Super! In a minute I'll push up a regression test (given that this regressed once already). |
jacobtylerwalls
changed the title
makeRests was called inPlace before copies were made. See cuthbertLab#1557
flat Part was going to need an additional deepcopy. Now, should not need one.
|
Thanks for the diagnosis and PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We copy the score object early to avoid modifying it when calling
.write("musicxml", *)See #1557
@jacobtylerwalls