fixed typos

customerio · Jan 10, 2025 · d591ef4 · d591ef4
1 parent cf466bb
commit d591ef4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/build-sample-apps.yml b/.github/workflows/build-sample-apps.yml
@@ -156,6 +156,7 @@ jobs:
         with:
           subdirectory: apps/${{ matrix.sample-app }}
           lane: 'android build'
+          options: '{"distribution_groups": "${{ env.firebase_distribution_groups }}"}'
         env:
           FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64: ${{ secrets.FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64 }}
         continue-on-error: true # continue to build iOS app even if Android build fails
@@ -182,6 +183,7 @@ jobs:
         with:
           subdirectory: apps/${{ matrix.sample-app }}
           lane: "ios build"
+          options: '{"distribution_groups": "${{ env.firebase_distribution_groups }}"}'
         env:
           GOOGLE_CLOUD_MATCH_READONLY_SERVICE_ACCOUNT_B64: ${{ secrets.GOOGLE_CLOUD_MATCH_READONLY_SERVICE_ACCOUNT_B64 }}
           FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64: ${{ secrets.FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64 }}

diff --git a/apps/fastlane/helpers/build_helper.rb b/apps/fastlane/helpers/build_helper.rb
@@ -5,7 +5,7 @@
 platform :android do
   lane :build do |values|
     build_notes = get_build_notes()
-    test_groups = get_build_test_groups(distribution_groups: arguments[:distribution_groups])
+    test_groups = get_build_test_groups(distribution_groups: values[:distribution_groups])
     app_package_name = CredentialsManager::AppfileConfig.try_fetch_value(:package_name) # get package_name from Appfile
 
     # Firebase app id is required. Fetch it from google-services.json file using app_package_name