-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional translations #29
Conversation
(Folder rename.. Who would've thought Android didn't use ISO 639-1 for Hebrew)
I meant only for the first 3 commits (those related to translations) to go into the pull request. The last one addresses issue #28. |
@Dev-iL would you mind sending the last commit as a separate PR? I would like to merge the PR for the translations separately |
@kiran I'll hopefully get to it today. Don't forget you can always
|
@curioustechizen I have rearranged my commits and now only the translations are in this PR. Would you still like me to submit the "data-binding example commit" as a PR, or will that just be a waste of everybody's time..? |
@Dev-iL Thanks a ton. I somehow forgot about cherrypicking (something that I don't have to do very often). I think a data binding sample would be very helpful to others. |
@curioustechizen Could you please merge the translations PR first? I don't see how I can create another PR w/o also including the commits that are already in this one.... |
As per #21