Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional translations #29

Merged
merged 5 commits into from
May 15, 2016
Merged

Conversation

Dev-iL
Copy link
Contributor

@Dev-iL Dev-iL commented Feb 5, 2016

As per #21

(Folder rename.. Who would've thought Android didn't use ISO 639-1 for
Hebrew)
@Dev-iL
Copy link
Contributor Author

Dev-iL commented Feb 6, 2016

I meant only for the first 3 commits (those related to translations) to go into the pull request. The last one addresses issue #28.

@curioustechizen
Copy link
Owner

@Dev-iL would you mind sending the last commit as a separate PR? I would like to merge the PR for the translations separately

@Dev-iL
Copy link
Contributor Author

Dev-iL commented May 15, 2016

@kiran I'll hopefully get to it today. Don't forget you can always
"cherry-pick" specific commits from a larger PR.
On May 15, 2016 1:13 AM, "Kiran Rao" [email protected] wrote:

@Dev-iL https://github.com/Dev-iL would you mind sending the last
commit as a separate PR? I would like to merge the PR for the translations
separately


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#29 (comment)

@Dev-iL
Copy link
Contributor Author

Dev-iL commented May 15, 2016

@curioustechizen I have rearranged my commits and now only the translations are in this PR. Would you still like me to submit the "data-binding example commit" as a PR, or will that just be a waste of everybody's time..?

@curioustechizen
Copy link
Owner

@Dev-iL Thanks a ton. I somehow forgot about cherrypicking (something that I don't have to do very often). I think a data binding sample would be very helpful to others.

@Dev-iL
Copy link
Contributor Author

Dev-iL commented May 15, 2016

@curioustechizen Could you please merge the translations PR first? I don't see how I can create another PR w/o also including the commits that are already in this one....

@curioustechizen curioustechizen merged commit f694533 into curioustechizen:master May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants