use Log.Error if returning false (#259)

don't use high priority for converting OriginUrl fix #201 fix #223
ctaggart · Sep 21, 2017 · 1e80c6d · 1e80c6d
1 parent 35b0ae6
commit 1e80c6d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/SourceLink.Create.CommandLine/CreateTask.cs b/SourceLink.Create.CommandLine/CreateTask.cs
@@ -30,14 +30,14 @@ public override bool Execute()
             {
                 if(OriginUrl == null)
                 {
-                    Log.LogMessage(MessageImportance.High, "OriginUrl not set");
+                    Log.LogError("OriginUrl not set");
                     return false;
                 }
                 url = ConvertUrl(OriginUrl);
-                Log.LogMessage(MessageImportance.High, "SourceLinkUrl: " + url);
+                Log.LogMessage(MessageImportance.Normal, "SourceLinkUrl: " + url);
                 if (url == null)
                 {
-                    Log.LogMessage(MessageImportance.High, "unable to convert OriginUrl: " + OriginUrl);
+                    Log.LogError("unable to convert OriginUrl: " + OriginUrl);
                     return false;
                 }
             }

diff --git a/SourceLink.Create.Shared/GitCreateTask.cs b/SourceLink.Create.Shared/GitCreateTask.cs
@@ -43,14 +43,14 @@ public override bool Execute()
                 var originCmd = Process.RunAndGetOutput("dotnet", originArgs);
                 if (originCmd.ExitCode != 0 || originCmd.OutputLines.Count != 1)
                 {
-                    Log.LogMessage(MessageImportance.High, "unable to find repository origin with: dotnet " + originArgs);
+                    Log.LogError("unable to find repository origin with: dotnet " + originArgs);
                     return false;
                 }
                 var origin = originCmd.OutputLines[0];
                 url = ConvertUrl(origin);
                 if (url == null)
                 {
-                    Log.LogMessage(MessageImportance.High, "unable to convert origin url: " + origin);
+                    Log.LogError("unable to convert origin url: " + origin);
                     return false;
                 }
             }

diff --git a/build.ps1 b/build.ps1
@@ -1,5 +1,5 @@
 $version = '2.3.0' # the version under development, update after a release
-$versionSuffix = '-a122' # manually incremented for local builds
+$versionSuffix = '-a124' # manually incremented for local builds
 
 function isVersionTag($tag){
     $v = New-Object Version