gammapy interface: 1D spectral analysis #33
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HealthyPear
force-pushed
the
feature-gammapy-1d-spectrum-estimation
branch
from
a524218 to
b09506e
Compare
- add plot_gammapy_sed add plot_irf_source_pointing Fix quotes formatting
HealthyPear
force-pushed
the
feature-gammapy-1d-spectrum-estimation
branch
from
ad0c372 to
6e61758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to tackle #3 by adding the 1D spectral analysis case (EBL absorption is not yet taken into account, I would leave that for a separate smaller PR).
The interface is activate by adding
--use-gammapyflagto the
runsubcommand and will produce an estimated SEDbased on the input data which can be either:
Sky models are defined from a
models.ymlfile instead than from the assumed_model section in the global config file (a next PR will unify the two - see #24).I plan to add also a check fo the IRF pointings with allowed maximum difference with respect to the target source,
in case the provided IRFs are not very suited for that particular observation.
P.S: still in draft because the numbers do not convince me...I also added a
get_wstat_tableto the interface module with which you should get the equivalent of Li&Ma bin-wise significance from the fakedspectrum_dataset_on_off, but the sigma showed on the SED plot correspond to gammapy likeyhood estimation.