Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SubarrayDescription.info for non-unique telescope description strings #2673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix SubarrayDescription.info for non-unique telescope description strings #2673

wants to merge 1 commit into from

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jan 9, 2025

Fixes #2672

@ctao-dpps-sonarqube CTAO-DPPS-SonarQube

This comment has been minimized.

Sign in to view
@maxnoe maxnoe force-pushed the fix_subarray_info branch from b3c1a19 to 3ba1f4b Compare January 9, 2025 13:42
kosack
kosack approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@kosack kosack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also makes me wonder why we have the same string rep for different types in the first place, but good to fix. Really, the telescope type string was supposed to have three parts:

  • a high-level type name: LST/MST/SST
  • a optics name
  • a camera name
    When anything changes in the description, the optics or camera name should also be changed, i,e by adding a version, but we don't enforce that. The optics name should not in general be just "LST" (which is redundant), but rather something version-able or that describes better the current optics design. I would expect in the future we could have e.g. 1: LST_v1_LSTCam, 2,3,4: LST_v2_LSTCam, but that needs to be done at the simualtion production level when setting the metadata.

@ctao-dpps-sonarqube CTAO-DPPS-SonarQube
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (93.50% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

@maxnoe maxnoe mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosack kosack kosack approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SubarrayDescrption missing telescopes in case of non-unique telescope description string
2 participants
@maxnoe @kosack