-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve column names for disp #2443
Conversation
Related: #2228 We could have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, but this requires a bump in the data model version,
an entry in the data model changelog and probably dropping support for reading older files.
And some tests and more code has to be adapted, see the test failures. |
3d7e628
to
da7bb4f
Compare
disp_parameter_is_valid
column, since it is identical to thedisp_tel_is_valid
column.DispContainer
and theReconstructedGeometryContainer
, as filled byDispReconstructor
.DispContainer
contains the output values of both the regressor (norm) and the classifier (sign) as a single value (sign * norm), I renamed this value to "parameter" to avoid confusion.HOWEVER:
DispReconstructor
still creates all the geometry-related columns contained inReconstructedGeometryContainer
even though it only computes altitude and azimuth. But since the creation of such empty columns is not limited to the disp reconstructor, I think it would be better to address this in a different PR.