Bump crossplane-runtime version to v1.18.0 #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cem Mergenci <[email protected]>
References: kubernetes/kubernetes#121970 kubernetes/apimachinery@126f5ce Signed-off-by: Cem Mergenci <[email protected]>
mergenci
force-pushed
the
bump-crossplane-runtime-v1.18.0
branch
from
b01c2bf to
5c4b81b
Compare
References: kubernetes/kubernetes#124263 kubernetes-sigs/controller-runtime#2799 Signed-off-by: Cem Mergenci <[email protected]>
mergenci
requested review from
ulucinar,
sergenyalcin and
erhancagirici
as code owners
erhancagirici
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Thanks for taking this over @mergenci, LGTM with some optional nits.
Also my recommendation: since this requires bumps in the controller-runtime library that has needs attention, consumers should be notified in the release notes, in case they might theoretically depend on these library in some other parts of their own code if any.
Maybe, having a release/tag pre-1.18 might be a good idea to give some more time to the consumers to bump.
| @@ -7,11 +7,11 @@ module github.com/crossplane/upjet | |||
| go 1.22.7 | |||
|
|
|||
| require ( | |||
| dario.cat/mergo v1.0.0 | |||
| dario.cat/mergo v1.0.1 | |||
| github.com/alecthomas/kingpin/v2 v2.4.0 | |||
| github.com/antchfx/htmlquery v1.2.4 | |||
| github.com/crossplane/crossplane v1.13.2 | |||
There was a problem hiding this comment.
nit: maybe updating crossplane/crossplane here is a good idea too, to match the runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested