Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kubernetes-provider quickstart #853

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cccsss01
Copy link

No description provided.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit e84364f
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/6791eda6dc51820008b628db
😎 Deploy Preview https://deploy-preview-853--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🟢 up 13 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

cccsss01 and others added 2 commits January 12, 2025 23:47
content/master/getting-started/provider-kubernetes.md Outdated Show resolved Hide resolved
content/master/getting-started/provider-kubernetes.md Outdated Show resolved Hide resolved
metadata:
name: provider-kubernetes
EOF
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing closing code block? or maybe one too much?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite know, this is what got it to work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The triple backtick to close the code block in markdown.

name: cluster-admin
apiGroup: rbac.authorization.k8s.io
EOF
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing close code block here too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand

content/master/getting-started/provider-kubernetes.md Outdated Show resolved Hide resolved
metadata:
name: provider-azure-network
spec:
package: xpkg.upbound.io/upbound/provider-kubernetes:v0.16.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package: xpkg.upbound.io/upbound/provider-kubernetes:v0.16.0
package: xpkg.upbound.io/upbound/provider-kubernetes:v0.16.2

content/master/getting-started/provider-kubernetes.md Outdated Show resolved Hide resolved
Comment on lines +38 to +49
```yaml
cat <<EOF | kubectl apply -f -
apiVersion: pkg.crossplane.io/v1beta1
kind: DeploymentRuntimeConfig
metadata:
name: provider-kubernetes
spec:
serviceAccountTemplate:
metadata:
name: provider-kubernetes
EOF
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 looks we are missing a story here. What's going on? should the section Create a ProviderConfig below be dropped?

Co-authored-by: Philippe Scorsolini <[email protected]>
Copy link
Author

@cccsss01 cccsss01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're asking for but this all works.

metadata:
name: provider-kubernetes
EOF
---
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite know, this is what got it to work

name: cluster-admin
apiGroup: rbac.authorization.k8s.io
EOF
---
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants