Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data (publish): convert Deeds pop-ups to footnotes and improve HTML5 compatibility #169

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

TimidRobot
Copy link
Member

@TimidRobot TimidRobot commented Nov 30, 2023

Description

Data (publish): convert Deeds pop-ups to footnotes and improve HTML5 compatibility

  • convert Deeds pop-ups to footnotes
  • add Lists and Deeds for translations that are now complete enough for display (>60% of strings translated):
    • fy Frisian (frysk)
    • sk Slovak (Slovensky)
  • improve HTML5 compatibility (ex. remove single tag closing slash)

See related App PR:

See related Data PR:

Review Guidelines

See Generated Files Review (generated_files_review.md).

Also with this branch checked out, you can review using creativecommons/index-dev-env.

Screenshots

CC BY 3.0 IGO Deed نَسب المُصنَّف 3.0 Intergovernmental Organization

🖼️ CC BY 3.0 IGO Deed نَسب المُصنَّف 3.0 Intergovernmental Organization

Screenshot 2023-11-30 at 05-58-20 CC BY 3 0 IGO Deed نَسب المُصنَّف 3 0 Intergovernmental Organization Creative Commons

CC BY 3.0 IGO Deed | Attribution 3.0 Intergovernmental Organization

🖼️ CC BY 3.0 IGO Deed | Attribution 3.0 Intergovernmental Organization

Screenshot 2023-11-30 at 05-58-38 CC BY 3 0 IGO Deed Attribution 3 0 Intergovernmental Organization Creative Commons

CC0 1.0 Deed | CC0 1.0 Universal

🖼️ CC0 1.0 Deed | CC0 1.0 Universal

Screenshot 2023-11-30 at 05-59-31 CC0 1 0 Deed CC0 1 0 Universal Creative Commons

PDM 1.0 Deed | Public Domain Mark 1.0 Universal

🖼️ PDM 1.0 Deed | Public Domain Mark 1.0 Universal

Screenshot 2023-11-30 at 05-59-37 PDM 1 0 Deed Public Domain Mark 1 0 Universal Creative Commons

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Base automatically changed from deeds-footnotes-gettext to main December 1, 2023 14:17
@TimidRobot TimidRobot merged commit cab4c92 into main Dec 1, 2023
1 check passed
@TimidRobot TimidRobot deleted the deeds-footnotes-publish branch December 1, 2023 14:18
@TimidRobot
Copy link
Member Author

TimidRobot commented Dec 1, 2023

deployed to production & staging Fri 01 Dec 2023 02:26:08 PM UTC (may take 30 minutes for caches to expire)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants