Cmpsr #438
Open
Cmpsr #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigk5n
reviewed
Aug 31, 2024
.gitignore
Outdated
| java/ | ||
| mysql-data | ||
| node_modules/ | ||
| pub/ |
There was a problem hiding this comment.
We don't want to ignore "pub" or "java"
|
I'd recommend smaller more focused PRs. (Keep the gitignore separate from the composer.json changes.) |
Craig, ingnoring 'pub' was an accident. I didn't realize 'java' is still being used.
|
Yeah, more focused. I try. Sometimes I commit the wrong branch and couldn't figure out how to undo it. I hope I'm getting better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking over composer.json from several projects.
Almost all of them have this config section.