Skip to content

Commit

Permalink
Merge pull request #99 from craftcms/bugfix/register_argc_argv
Browse files Browse the repository at this point in the history
Default register_argc_argv to off
  • Loading branch information
timkelty authored Dec 19, 2024
2 parents b3c02dc + 68a2a6d commit 3d27ef3
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions 8.0/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ ARG PHP_MAX_INPUT_VARS_ARG="1000"
ENV PHP_MAX_INPUT_VARS=${PHP_MAX_INPUT_VARS_ARG}
ARG PHP_POST_MAX_SIZE_ARG="8M"
ENV PHP_POST_MAX_SIZE=${PHP_POST_MAX_SIZE_ARG}
ARG PHP_REGISTER_ARGC_ARGV="0"
ENV PHP_REGISTER_ARGC_ARGV=${PHP_REGISTER_ARGC_ARGV}

# setup opcache for environment variables
ARG PHP_OPCACHE_ENABLE_ARG="1"
Expand Down
1 change: 1 addition & 0 deletions 8.0/craft-cms.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ max_execution_time=${PHP_MAX_EXECUTION_TIME}
upload_max_filesize=${PHP_UPLOAD_MAX_FILESIZE}
max_input_vars=${PHP_MAX_INPUT_VARS}
post_max_size=${PHP_POST_MAX_SIZE}
register_argc_argv=${PHP_REGISTER_ARGC_ARGV}
[opcache]
opcache.enable=${PHP_OPCACHE_ENABLE}
opcache.revalidate_freq=${PHP_OPCACHE_REVALIDATE_FREQ}
Expand Down
2 changes: 2 additions & 0 deletions 8.1/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ ARG PHP_MAX_INPUT_VARS_ARG="1000"
ENV PHP_MAX_INPUT_VARS=${PHP_MAX_INPUT_VARS_ARG}
ARG PHP_POST_MAX_SIZE_ARG="8M"
ENV PHP_POST_MAX_SIZE=${PHP_POST_MAX_SIZE_ARG}
ARG PHP_REGISTER_ARGC_ARGV="0"
ENV PHP_REGISTER_ARGC_ARGV=${PHP_REGISTER_ARGC_ARGV}

# setup opcache for environment variables
ARG PHP_OPCACHE_ENABLE_ARG="1"
Expand Down
1 change: 1 addition & 0 deletions 8.1/craft-cms.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ max_execution_time=${PHP_MAX_EXECUTION_TIME}
upload_max_filesize=${PHP_UPLOAD_MAX_FILESIZE}
max_input_vars=${PHP_MAX_INPUT_VARS}
post_max_size=${PHP_POST_MAX_SIZE}
register_argc_argv=${PHP_REGISTER_ARGC_ARGV}
[opcache]
opcache.enable=${PHP_OPCACHE_ENABLE}
opcache.revalidate_freq=${PHP_OPCACHE_REVALIDATE_FREQ}
Expand Down
2 changes: 2 additions & 0 deletions 8.2/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ ARG PHP_MAX_INPUT_VARS_ARG="1000"
ENV PHP_MAX_INPUT_VARS=${PHP_MAX_INPUT_VARS_ARG}
ARG PHP_POST_MAX_SIZE_ARG="8M"
ENV PHP_POST_MAX_SIZE=${PHP_POST_MAX_SIZE_ARG}
ARG PHP_REGISTER_ARGC_ARGV="0"
ENV PHP_REGISTER_ARGC_ARGV=${PHP_REGISTER_ARGC_ARGV}

# setup opcache for environment variables
ARG PHP_OPCACHE_ENABLE_ARG="1"
Expand Down
1 change: 1 addition & 0 deletions 8.2/craft-cms.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ max_execution_time=${PHP_MAX_EXECUTION_TIME}
upload_max_filesize=${PHP_UPLOAD_MAX_FILESIZE}
max_input_vars=${PHP_MAX_INPUT_VARS}
post_max_size=${PHP_POST_MAX_SIZE}
register_argc_argv=${PHP_REGISTER_ARGC_ARGV}
[opcache]
opcache.enable=${PHP_OPCACHE_ENABLE}
opcache.revalidate_freq=${PHP_OPCACHE_REVALIDATE_FREQ}
Expand Down

0 comments on commit 3d27ef3

Please sign in to comment.