Skip to content

Commit

Permalink
Fix bug in sDAI slippage accounting (#370)
Browse files Browse the repository at this point in the history
Accounting of sDAI imbalance was not done currectly for these two txs:


https://etherscan.io/tx/0x6f8f9381c8165802523ff434573d5ce2087cd0dac544b548e92189753d424815


https://etherscan.io/tx/0x2c0b7b504733dcb3a23d385515755a781fd2589aa9ff9e4250366edb0e6bc705

This PR fixes the issue; the fix itself was proposed by @fhenneke 

The relevant Dune queries have already been updated.
  • Loading branch information
harisang authored Jun 25, 2024
1 parent 7b403d7 commit f72db36
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion queries/dune_v2/period_slippage.sql
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ block_range as (
from batch_meta bm
join maker_ethereum.SavingsDai_evt_Withdraw w
on w.evt_tx_hash= bm.tx_hash
where sender = 0x9008d19f58aabd9ed0d60971565aa8510560ab41
where owner = 0x9008d19f58aabd9ed0d60971565aa8510560ab41
union all
-- deposit events result in additional AMM_OUT transfer
select
Expand Down

0 comments on commit f72db36

Please sign in to comment.