Remove full_fee_amount and solver_fee #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable). Caused by: |
|
Reminder: Please consider backward compatibility when modifying the API specification.
Caused by: |
MartinquaXD
approved these changes
Jan 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of fee breakdown refactor, the time has come to remove
full_fee_amountandsolver_feefrom order API.These fields were relevant more than 2 years ago when orders with signed fee > 0 existed and when subsidies for that fee were calculated.
Will wait for confirmation from frontend that these fields are no longer used anywhere, before merging.
Changes
How to test
Existing unit tests, e2e tests, postgresql tests.