Bad token detection: only transfer as much as is available #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
changed the title
squadgazzz
approved these changes
Dec 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new bad token detection in the driver identified some sell tokens as unsupported although they are perfectly fine
(example order)
The reason is probably that the test transfer the bad token detection currently always uses the order's full signed sell amount. This will fail if the user created a partially fillable order where the sell amount exceeds their current balance.
Changes
Adjusted the test transfer to only transfer the
order.partial.availableamount (when applicable). This value takes partial fills of the given order and the user's current balance into account.