chore: remove xmas/halloween feature flags #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
elena-zh
approved these changes
Jan 8, 2025
alfetopito
force-pushed
the
chore/remove-xmas-feature-flag
branch
from
a3832a4 to
3b42e97
Compare
alfetopito
changed the title
alfetopito
changed the title
anxolin
reviewed
Jan 9, 2025
| @@ -47,7 +45,12 @@ function isDarkMode(): boolean { | |||
| } | |||
|
|
|||
| function getThemeBasedSound(type: SoundType): string { | |||
| const featureFlags = jotaiStore.get(featureFlagsAtom) as Record<string, boolean> | |||
| // TODO: load featureFlags when enabling again | |||
There was a problem hiding this comment.
nit: leave it like this, but here not sure you should leave a TODO. We really won't do anything here. We will just come back when we have another seasonal theme, but this TODO is something we don't want to act right now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only preventing the flags from being loaded from Launch Darkly.
All the functionality is still there.
To Test