Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network selector #5264

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Network selector #5264

merged 3 commits into from
Jan 9, 2025

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Dec 31, 2024 •
edited
Loading

Summary

This PR:

  • Delete the feature flag from isBaseEnabled
  • Add a NEW badge in base, to show is a new network
image image

CTX: https://cowservices.slack.com/archives/C06G1E3AU77/p1735549193334069

The message of BASE launch has been long enough.

image

The NEW badge is less annoying

@vercel Vercel
Copy link

vercel bot commented Dec 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cowfi ✅ Ready (Inspect) Visit Preview Jan 9, 2025 2:40pm
explorer-dev ✅ Ready (Inspect) Visit Preview Jan 9, 2025 2:40pm
swap-dev ✅ Ready (Inspect) Visit Preview Jan 9, 2025 2:40pm
3 Skipped Deployments
Name Status Preview Updated (UTC)
cosmos ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 2:40pm
sdk-tools ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 2:40pm
widget-configurator ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 2:40pm

@anxolin anxolin requested a review from a team December 31, 2024 10:43
@anxolin anxolin changed the base branch from develop to main December 31, 2024 11:07
@anxolin anxolin requested a review from a team January 2, 2025 10:29
elena-zh
elena-zh reviewed Jan 8, 2025
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @anxolin , great, thank you!
Just a tiny nitpick: looks like the label is glued to the green indicator when Base is selected:
image
And the 'new' label is hardly visible in the light mode
image

Could you please fix it? ;)

@anxolin
Copy link
Contributor Author

anxolin commented Jan 9, 2025 •
edited
Loading

@elena-zh I tried to solve the 2 issues

image image image

@anxolin anxolin requested review from alfetopito and elena-zh January 9, 2025 14:27
@anxolin anxolin enabled auto-merge (squash) January 9, 2025 14:28
elena-zh
elena-zh approved these changes Jan 9, 2025
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @anxolin , thank you!
I'm approving, but just in case, I'm letting you know that now we have different styles for the 'NEW' label :)
image

@anxolin anxolin merged commit 1b4cfc1 into main Jan 9, 2025
13 checks passed
@anxolin anxolin deleted the network-selector branch January 9, 2025 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@alfetopito alfetopito Awaiting requested review from alfetopito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anxolin @alfetopito @elena-zh