Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(widget): do not display Christmas background #5250

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix(widget): do not display Christmas background #5250

merged 2 commits into from
Dec 23, 2024

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Dec 23, 2024 •
edited
Loading

Summary

Fixes #5247, #5242

After adding Christmas theme we have broken the widget background in small resolutions.

image

To Test

  1. Open a widget configurator
  2. Make your window size smaller
  • AR: the Christmas background is displayed
  • ER: the Christmas background is NOT displayed

@shoom3301 shoom3301 added the RELEASE Included in the release that is being closed label Dec 23, 2024
@shoom3301 shoom3301 requested review from a team December 23, 2024 08:34
@shoom3301 shoom3301 self-assigned this Dec 23, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 23, 2024 9:17am
cowfi ✅ Ready (Inspect) Visit Preview Dec 23, 2024 9:17am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 23, 2024 9:17am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 23, 2024 9:17am
swap-dev ✅ Ready (Inspect) Visit Preview Dec 23, 2024 9:17am
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 23, 2024 9:17am

@shoom3301
Copy link
Collaborator Author

@elena-zh I also fixed #5242 in this PR

elena-zh
elena-zh approved these changes Dec 23, 2024
View reviewed changes
Copy link

@elena-zh elena-zh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

The issue is still reproducible with this banner, but it is not a priority atm
image

@shoom3301 shoom3301 merged commit 8b6180c into main Dec 23, 2024
12 of 13 checks passed
@shoom3301 shoom3301 deleted the fix/chrismas-theme-widget branch December 23, 2024 09:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
anxolin
anxolin reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. It looks like this PR includes 2 fixes, not just the background
It fixes the snackbar positioning for widget mode, right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@elena-zh elena-zh elena-zh approved these changes

Assignees

@shoom3301 shoom3301

Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @anxolin @elena-zh