Reapply "feat(wallets): add metaMask SDK connector (#5028)" (#5215) #5223
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@EdouardBougon is attempting to deploy a commit to the cow Team on Vercel. A member of the Team first needs to authorize it. |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Hey @EdouardBougon , thank you for recreating the PR and retesting it!
I've also done a test round with all scenarios you mentioned, and everything is working great to me.
I'm not sure what caused issues I reported in #5028 (comment). They might have been related to our dev environment (no a PR), so I will double check them as soon as this PR is merged there.
|
Report too large to display inline |
|
@EdouardBougon , could you please clarify whether I should do another test round after your latest changes? |
|
It’s a minor fix that should not affect your tests. |
Linked to: #5028 and #5125
First of all, thank you for merging and testing our PR #5028.
This PR is a response to the comment #issuecomment-2548145513 from @elena-zh
I just tested the version deployed by your CI/CD here:
https://github.com/cowprotocol/cowswap/actions/runs/12352101138/job/34468407595#step:8:17
And I tested the following scenarios:
• Connection and signing on Desktop with the extension via the SDK
• Connection and signing on Desktop without the extension via the SDK + mobile
• Connection and signing on Desktop without the extension via WC + mobile
• Connection and signing on Mobile via the SDK
• Connection and signing on Mobile via WC
For all these scenarios, I was not able to reproduce the issues you mentioned.
Could I get more information about your test environment?
I’m available for a call and a live test if needed.