fix(orders-table): display allowance warning in Safe #5207
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @shoom3301 , everything looks good besides one bug (#3480) that has become reproducible here again |
|
@elena-zh thank you! Fixed that. |
| ) | ||
|
|
||
| const withAllowanceWarning = hasEnoughAllowance === false && hasValidPendingPermit === false | ||
| const withAllowanceWarning = hasEnoughAllowance === false |
There was a problem hiding this comment.
Now it's simplier, hasEnoughAllowance already includes result of permit checks
| @@ -43,7 +45,7 @@ export function getOrderParams( | |||
| partiallyFillable: order.partiallyFillable, | |||
| sellAmount, | |||
| balance, | |||
| allowance, | |||
| allowance: getBiggerAmount(allowance, permitAmount), | |||
There was a problem hiding this comment.
I take allowance value from blockchain OR permit value from order appData, depending on what is bigger
| }, {} as { [key: string]: true }) | ||
| return acc | ||
| }, | ||
| {} as { [key: string]: true }, |
There was a problem hiding this comment.
nit, you can also specify the type without the casting selectedOrders.reduce<[key: string]: true>
Summary
Fixes #4076
hasValidPendingPermitcan beundefinedTo Test
This issue was introduced in #3487, so please make sure this issue is not back.
See #4076