feat: style TWAP warning banner #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
approved these changes
Dec 13, 2024
elena-zh
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Hey @fairlighteth , great!
However, is this OK that we have a bit different text for the fallback handler on 2 related warnings which can be displayed at the same time?
I'm not sure here, would it be possible to have the same style for the warning icon? At the top, it is displayed from the left. At the bottom, it is center-aligned.
Also, there is a typo in the text, could you please fix it?
|
@elena-zh pushed some changes:
As for the other item, I'd say out of scope for this particular PR. IMO we need to assess this separately. 
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary