fix(twap): display a warning when fbh was changed after twap order #5202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elena-zh
approved these changes
Dec 13, 2024
* feat: style TWAP warning banner * feat: fix typo and change orientation of banner
|
Merged #5204 PR from @fairlighteth with design changes in this PR |
anxolin
approved these changes
Dec 17, 2024
| const txHash = await setupFallbackHandler() | ||
|
|
||
| if (txHash) { | ||
| setPendingTxHash(txHash) |
There was a problem hiding this comment.
A re-render of this would loose the posted TX, right?
There was a problem hiding this comment.
Nice catch!
Fixed it: 35f1802
Thanks!
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since fb handler might be changed in a random moment, we should handle the case.
We recently added the fb handler verification cache invalidation - #5200.
In this PR I added a banner which is displayed when fb handler is not installed and there are open TWAP orders.
I know, the banner is ugly, @fairlighteth please help 🙏
To Test
If you need to reset a fn handler, just create a transaction via transaction builder:
0xf08a032300000000000000000000000075cf11467937ce3f2f357ce24ffc3dbf8fd5c226And don't forget to remove
fallbackHandlerVerificationlocalStorage key after that