-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(twap): cache fb handler verification for 10min #5200
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -25,12 +25,14 @@ export async function verifyExtensibleFallback( | |||
try { | |||
const domainVerifier = await signatureVerifierContract.callStatic.domainVerifiers(safeAddress, domainSeparator) | |||
|
|||
console.log('FALLBACK HANDLER CHECKED, domainVerifier: ', domainVerifier) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: remove after testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for me, but why not using joitai?
@anxolin this is a good question. |
fine, not big deal, just saying the initial value could be:
|
@anxolin waaaait, I actually forgot about |
Summary
Related to #2949
Since Safe fallback handler might be changed any time, we should not cache the fb verification result for ever.
In this PR I added cache life time - 10 minutes.
To Test