Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cowfi): reduce cms requests cache time to 5 min #5196

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(cowfi): reduce cms requests cache time to 5 min #5196

merged 1 commit into from
Dec 12, 2024

Conversation

shoom3301
Copy link
Collaborator

Summary

Marketing needs the articles to be updated faster.

@shoom3301 shoom3301 added the RELEASE Included in the release that is being closed label Dec 12, 2024
@shoom3301 shoom3301 requested review from a team December 12, 2024 14:52
@shoom3301 shoom3301 self-assigned this Dec 12, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 12, 2024 3:02pm
cowfi ✅ Ready (Inspect) Visit Preview Dec 12, 2024 3:02pm
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 12, 2024 3:02pm
sdk-tools 🔄 Building (Inspect) Visit Preview Dec 12, 2024 3:02pm
swap-dev ✅ Ready (Inspect) Visit Preview Dec 12, 2024 3:02pm
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 12, 2024 3:02pm

@shoom3301
Copy link
Collaborator Author

@alfetopito I hope you don't mind if I merge it, the fix is straightforward enough

@shoom3301 shoom3301 merged commit 8893f35 into main Dec 12, 2024
8 of 11 checks passed
@shoom3301 shoom3301 deleted the fix/cow-fi-cache-time branch December 12, 2024 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@vercel vercel bot temporarily deployed to Preview – explorer-dev December 12, 2024 15:03 Inactive
alfetopito
alfetopito reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this have an impact in the cost reduction measures you worked on this week?
In other words, how much more can this change cost?

@shoom3301
Copy link
Collaborator Author

shoom3301 commented Dec 12, 2024 •
edited
Loading

In other words, how much more can this change cost?

Not so much, <1k$ a month
Actually it shouldn't even be noticeable, before the recent refactoring we didn't have cache at all, so we have been rendering the pages on each user request.
Now we cache it and revalidate the cache once in 5 mins, so the pages rendering now doesn't depend on users requests count.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito left review comments

Assignees

@shoom3301 shoom3301

Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoom3301 @alfetopito