Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(widget): polish configurator #3380

Merged
merged 5 commits into from
Nov 10, 2023
Merged

fix(widget): polish configurator #3380

merged 5 commits into from
Nov 10, 2023

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Nov 10, 2023 •
edited
Loading

Summary

Context: https://cowservices.slack.com/archives/C0361CDG8GP/p1699611823321549

What is fixed:

  1. Changed favicon (put the same as in swap.cow.fi)
  2. Renamed "Trade Modes" to "Trade types" to be consistent
  3. Fixed the case when sell token is not set the but token takes its place
  4. Fixed the example of embed code for react (added missing import)
  5. Fixed selecting of "auto" value for theme
  6. Explained why UNI token can't be selected by a symbol
  7. Fixed "View embed code" hover area (read more)

@shoom3301 shoom3301 added RELEASE Included in the release that is being closed Widget labels Nov 10, 2023
@shoom3301 shoom3301 requested a review from a team November 10, 2023 12:29
@shoom3301 shoom3301 self-assigned this Nov 10, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Nov 10, 2023 0:30am
swap-dev ✅ Ready (Inspect) Visit Preview Nov 10, 2023 0:30am
widget-configurator ✅ Ready (Inspect) Visit Preview Nov 10, 2023 0:30am

alfetopito
alfetopito approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shoom3301 shoom3301 changed the base branch from main to hotfix/1.49.2 November 10, 2023 13:48
@anxolin anxolin changed the base branch from hotfix/1.49.2 to hotfix/1.49.3 November 10, 2023 18:39
@anxolin anxolin merged commit 21545b9 into hotfix/1.49.3 Nov 10, 2023
7 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@alfetopito alfetopito deleted the fix/widget-polish branch November 13, 2023 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@alfetopito alfetopito alfetopito approved these changes

Assignees

@shoom3301 shoom3301

Labels
RELEASE Included in the release that is being closed Widget
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @alfetopito @anxolin