Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wc): add back patch which fixes WC path issue #3230

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(wc): add back patch which fixes WC path issue #3230

merged 1 commit into from
Oct 16, 2023

Conversation

alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Oct 16, 2023 •
edited
Loading

Summary

Fixes latest release issue with WC.

We did not notice but, this file was removed by mistake in the last PR part of the release.
And I failed to check WC on barn and staging.

To Test

  1. Open the app
  2. Connect with WC v2
  • Should succeed
  1. Place some orders
  • Should work as expected
  1. Try to connect other WC based wallets, such as Ambire, Trust and Alpha
  • All of them should connect as expected

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview Oct 16, 2023 4:09pm

🌃 Cosmos ↗︎

@alfetopito alfetopito changed the base branch from develop to hotfix/1.48.1 October 16, 2023 16:07
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@alfetopito alfetopito added the RELEASE Included in the release that is being closed label Oct 16, 2023
@alfetopito alfetopito self-assigned this Oct 16, 2023
@alfetopito alfetopito requested a review from a team October 16, 2023 16:10
@alfetopito alfetopito marked this pull request as ready for review October 16, 2023 16:10
@alfetopito
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 16, 2023
@github-actions
@alfetopito has signed the CLA from Pull Request #3230
fb5b324
@alfetopito alfetopito merged commit 7508c3b into hotfix/1.48.1 Oct 16, 2023
7 of 9 checks passed
@alfetopito alfetopito deleted the fix-wc branch October 16, 2023 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees

@alfetopito alfetopito

Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfetopito @shoom3301