Widget UI 6 #3220

fairlighteth · 2023-10-12T17:27:49Z

Summary

yarn start-widget
General widget improvements

* chore: fix cosmos CI * chore: fix cosmos CI

* chore: change TradeType enum from number to string * refactor: minor linting * fix: do not pass a obj key with undefined * chore: add TradeType to TradeDerivedState * feat: add const with mapping of order types and whether it supports permit ⚠️ limit permit support is disabled * feat: require TradeType to indentify whether token is permittable * chore: reset permit hook data when there are no pemrit params * fix: unit tests

Co-authored-by: Michel <[email protected]>

…ol/hotfix/1.47.1 Hotfix/1.47.1 release-as: 1.47.1

…ain--components--release-please-action chore(main): release 1.47.1

* feat: skeleton for SelectTokenModal * chore: setup SelectTokenModal cosmos * chore: styles SelectTokenModal * chore: select token modal styles

* feat: remove walletConnect v1 and use v2 by default * chore: walletconnect icon * chore: remove tooltip

* feat: skeleton for SelectTokenModal * chore: setup SelectTokenModal cosmos * chore: styles SelectTokenModal * chore: select token modal styles * feat: html of ManageListsAndTokens * chore: manage lists styles * chore: manage tokens styles * chore: import token from blockchain UI * chore: search tokens sources * chore: extract ModalHeader component * chore: component ImportTokenModal * chore: manage lists states * chore: component ImportListModal * chore: fix build

* refactor: extract NewModal into its own folder * refactor: only set permitInfo if there is not enough allowance * refactor: use setter to load current state rather than relying on stale one * feat: store permit status on swap state * fix: remove hasEnoughAllowance from TradeFlowContext * chore: use relative imports inside the module * feat: add PermitModal pure and container * chore: export cosmos command for easier access * refactor: simplify TokenAmount interface (it was doubling Nullish<>) * refactor: sort imports * chore: pass trade and swapConfirmState to TransactionConfirmationModal * feat: add PermitModal to TransactionConfirmationModal * chore: redid the logic to update the signature requesting * refactor: always set permitSignatureState * chore: remove stale comment * chore: update handlePermit export to fix build warning * chore: outputAmountWithoutFee never needed to be optional * chore: use TradeAmounts instead of TradeGp

* chore: turn permit on for LIMIT * fix: typo * refactor: beforeTrade is always set * refactor: optimize/refactor derived atoms * feat: add permitSignatureState and setPermitSignatureRequestedTradeConfirmAtom * feat: add requestPermitSignature action * refactor: extract buildTradeAmounts local fn * feat: add beforePermit to limitOrders tradeFlow * feat: show PermitModal for LIMIT * feat: fix new cow modal styles (#3177) * feat: fix new cow modal styles * feat: fix new cow modal styles * feat: fix new cow modal styles --------- Co-authored-by: Michel <[email protected]> * chore: add order type to PermitModal * refactor: clean up TradeConfirmalModal * fix: pass along PermitModal props to Pure component * chore: remove comment about backend PR, which has been merged --------- Co-authored-by: fairlight <[email protected]> Co-authored-by: Michel <[email protected]>

* refactor: move permit/state/atoms.ts to permittableTokensAtom.ts * feat: add permitCacheAtoms * feat: add useGeneratePermitHook * feat: remove localStorage caching from generatePermitHook * feat: replace generatePermitHook with useGeneratePermitHook * test: update unit tests * refactor: export * from permit hooks rather than individual exports * chore: throw when permitData cannot be generated by generatePermitHook * chore: fix comment * refactor: there's no need to pass an extra preFetchedNonce param * refactor: create curried fn to avoid repetition

* refactor: remove unnecessary toString() * chore: fix typo * fix: transform BigNumber instances into hex strings for compatibility with 1inch lib * feat: add fullAppData to local order instance * feat: add decodeAppData to appData module * feat: add getAppDataHooks to appData module * feat: add useCheckHasValidPendingPermit to permit module * feat: add permit checking to OrderRow allowance warning * refactor: rename getParsedOrderFromItem to getParsedOrderFromTableItem * refactor: change isParsed order to be a bit more semantic * feat: add ordersPermitStatusAtom * feat: add PendingPermitUpdater * feat: add useGetOrdersPermitStatus * feat: pass down ordersPermitStatus * feat: add PendingPermitUpdater to OrdersTableWidget * chore: remove unused export * refactor: sort exports * fix: add back export. I removed the wrong one 🤦 * refactor: extract useGetOrdersToCheckPendingPermit * chore: debug statements * fix: force atoms to load so stored value is respected * refactor: use the handy atomWithPartialUpdate * refactor: move useGetOrdersToCheckPendingPermit to its own file

vercel · 2023-10-12T17:27:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
swap-dev	✅ Ready (Inspect)	Visit Preview	Oct 16, 2023 11:33am

🌃 Cosmos ↗︎

…velop

* chore: remove unused prop `gasLimit` from SupportedPermitInfo * feat: query and add version to permitInfo * feat: bump permittableTokensAtom storage key to `v1` * fix: usdc default tokens had the wrong name, causing the permit signature to fail * chore: temporarily logging permit callData and params * fix: hack to fix USDC token name when creating the permit callData * feat: do not check for permit version if token cannot handle it * chore: remove console logs

…velop

* feat: move USDC name hack to a utils fn fixTokenName * fix: apply USDC token name fix to valid permit check as well * feat: add useGetPermitInfo * feat: use PermitInfo when checking for pending permit

… widget-ui-6 # Conflicts: # package.json # yarn.lock

anxolin

I tried to review, but I will need to allocate more time. It has 6K changes 🤯

You will get merge conflicts if you don't start to merge to develop (and cleanup).
So we will need to consolidate soon

anxolin · 2023-10-19T18:42:11Z

apps/cowswap-frontend/src/common/pure/NewModal/index.cosmos.tsx

@@ -0,0 +1,85 @@
+import ICON_ARROW from 'assets/icon/arrow.svg'


NewModal? I would avoid naming it like this. Later we will have NewNewModal :)

Or this is part of a plan of replacing the modals and it will be renamed later?

anxolin · 2023-10-19T18:45:56Z

apps/cowswap-frontend/src/common/pure/NewModal/index.cosmos.tsx

+`
+
+const ModalFixtures = {
+  'new modal + content top/bottom': (


I would think fixtures should be more simple, just as a show case with minimal code.

Also, its a bit hard to see the modal boundaries currently since the bg color in the fixture is the same as the modal:

Is this the component you wanted to have a BACK button instead of a close?

shoom3301 and others added 24 commits September 28, 2023 06:09

chore: fix cosmos CI (#3163)

48af810

* chore: fix cosmos CI * chore: fix cosmos CI

refactor: removed unused code (#3157)

0b66ae7

feat: update approve button color (#3169)

802f288

Co-authored-by: Michel <[email protected]>

chore(release): hotfix 1.47.1 Merge pull request #3171 from cowprotoc…

ce8671f

…ol/hotfix/1.47.1 Hotfix/1.47.1 release-as: 1.47.1

chore(main): release 1.47.1

cb26ea5

Merge branch 'main' into develop

9b384ef

Merge pull request #3172 from cowprotocol/release-please--branches--m…

1e87615

…ain--components--release-please-action chore(main): release 1.47.1

feat(tokens): new UI component for token select modal (#3166)

d5b69cd

* feat: skeleton for SelectTokenModal * chore: setup SelectTokenModal cosmos * chore: styles SelectTokenModal * chore: select token modal styles

feat: remove walletConnect v1 and use v2 by default (#3156)

4b3fbc0

* feat: remove walletConnect v1 and use v2 by default * chore: walletconnect icon * chore: remove tooltip

refactor: remove unused hooks (#3175)

488c926

refactor: remove unused code (#3181)

57637ef

chore: simplify menu (#3206)

4481465

refactor(permit): refactor checkIsTokenPermittable (#3204)

5de0df4

Merge remote-tracking branch 'origin/release/1.48.0' into develop

11d7e7c

feat: widget configurator app

30565eb

feat(permit): disable permit for SC wallets (#3213)

29e5178

Merge remote-tracking branch 'origin/release/1.48.0' into develop

a11703f

feat: widget configurator app

64c8533

feat: widget configurator app

d0b064e

vercel bot deployed to Preview October 12, 2023 17:34 View deployment

feat: widget configurator app

6c39e14

vercel bot deployed to Preview October 12, 2023 17:36 View deployment

feat: widget configurator app

8638950

shoom3301 and others added 13 commits October 17, 2023 02:50

chore(main): release 1.48.1 (#3233)

409e60e

fix(swap): don't reset swap form on recipient ens input (#3234)

9c1f2f1

Merge branch 'main' of https://github.com/cowprotocol/cowswap into de…

250da7a

…velop

chore(main): release 1.48.2 (#3235)

3ee3f3f

fix: display trade menu item badge (#3236)

9d54b0a

chore(main): release 1.48.3 (#3238)

1717cf9

Merge branch 'main' of https://github.com/cowprotocol/cowswap into de…

b61920a

…velop

chore(main): release 1.48.4 (#3239)

298e46e

Merge remote-tracking branch 'origin/main' into develop

f5a92b5

feat: deploy to IPFS (#3237)

e69af4d

Merge branch 'main' into develop

5ed0800

refactor: extract AccountElement and AccountModalState

0abd19e

vercel bot deployed to Preview October 18, 2023 13:24 View deployment

shoom3301 and others added 8 commits October 18, 2023 13:49

fix: display token logos from CoW Protocol correctly (#3244)

caaf980

chore(main): release 1.48.5 (#3246)

878afbb

Merge branch 'main' of https://github.com/cowprotocol/cowswap into de…

7810c75

…velop

fix(permit): usdc limit orders warning (#3247)

d958d0f

* feat: move USDC name hack to a utils fn fixTokenName * fix: apply USDC token name fix to valid permit check as well * feat: add useGetPermitInfo * feat: use PermitInfo when checking for pending permit

chore(main): release 1.48.6 (#3249)

80cb391

Merge remote-tracking branch 'origin/main' into develop

ce3e1b3

Merge branch 'develop' of https://github.com/cowprotocol/cowswap into…

c7e94e0

… widget-ui-6 # Conflicts: # package.json # yarn.lock

chore: update yarn.lock

3e78f09

vercel bot deployed to Preview October 19, 2023 08:53 View deployment

chore: fix code style

7f5b699

vercel bot deployed to Preview October 19, 2023 09:27 View deployment

anxolin self-requested a review October 19, 2023 18:05

anxolin reviewed Oct 19, 2023

View reviewed changes

fairlighteth closed this Oct 20, 2023

github-actions bot locked and limited conversation to collaborators Oct 20, 2023

fairlighteth deleted the widget-ui-6 branch July 4, 2024 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Widget UI 6 #3220

Widget UI 6 #3220

fairlighteth commented Oct 12, 2023 •

edited

Loading

vercel bot commented Oct 12, 2023 •

edited by github-actions bot

Loading

anxolin left a comment

anxolin Oct 19, 2023

anxolin Oct 19, 2023

anxolin Oct 19, 2023

		@@ -0,0 +1,85 @@
		import ICON_ARROW from 'assets/icon/arrow.svg'

Widget UI 6 #3220

Widget UI 6 #3220

Conversation

fairlighteth commented Oct 12, 2023 • edited Loading

Summary

vercel bot commented Oct 12, 2023 • edited by github-actions bot Loading

anxolin left a comment

Choose a reason for hiding this comment

anxolin Oct 19, 2023

Choose a reason for hiding this comment

anxolin Oct 19, 2023

Choose a reason for hiding this comment

anxolin Oct 19, 2023

Choose a reason for hiding this comment

fairlighteth commented Oct 12, 2023 •

edited

Loading

vercel bot commented Oct 12, 2023 •

edited by github-actions bot

Loading