fix: take permit amount into account when caching

cowprotocol · Dec 25, 2024 · 70b26a8 · 70b26a8
1 parent 7d412c5
commit 70b26a8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/apps/cowswap-frontend/src/modules/permit/state/permitCacheAtom.ts b/apps/cowswap-frontend/src/modules/permit/state/permitCacheAtom.ts
@@ -36,6 +36,7 @@ export const storePermitCacheAtom = atom(null, (get, set, params: StorePermitCac
   const dataToCache: CachedPermitData = {
     hookData: params.hookData,
     nonce: params.nonce,
+    amount: params.amount?.toString(),
   }
 
   set(atomToUpdate, (permitCache) => ({ ...permitCache, [key]: JSON.stringify(dataToCache) }))
@@ -61,7 +62,7 @@ export const getPermitCacheAtom = atom(null, (get, set, params: GetPermitCachePa
   }
 
   try {
-    const { hookData, nonce: storedNonce }: CachedPermitData = JSON.parse(cachedData)
+    const { hookData, nonce: storedNonce, amount }: CachedPermitData = JSON.parse(cachedData)
 
     if (params.account !== undefined) {
       // User type permit cache, check the nonce
@@ -76,6 +77,10 @@ export const getPermitCacheAtom = atom(null, (get, set, params: GetPermitCachePa
 
         return undefined
       }
+
+      if (params.amount) {
+        return params.amount.toString() === amount
+      }
     }
 
     // Cache hit for both static and user permit types

diff --git a/apps/cowswap-frontend/src/modules/permit/types.ts b/apps/cowswap-frontend/src/modules/permit/types.ts
@@ -33,6 +33,7 @@ export type PermitCache = Record<string, string>
 export type CachedPermitData = {
   hookData: PermitHookData
   nonce: number | undefined
+  amount: string | undefined
 }
 
 export type PermitCacheKeyParams = {