fix(orders-table): display allowance warning in Safe

cowprotocol · Dec 16, 2024 · 44310e8 · 44310e8
1 parent c45b37d
commit 44310e8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/OrderRow/index.tsx b/apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/OrderRow/index.tsx
@@ -173,10 +173,10 @@ export function OrderRow({
   }, [orderActions, order])
   const alternativeOrderModalContext = useMemo(
     () => orderActions.getAlternativeOrderModalContext(order),
-    [order, orderActions]
+    [order, orderActions],
   )
 
-  const withAllowanceWarning = hasEnoughAllowance === false && hasValidPendingPermit === false
+  const withAllowanceWarning = hasEnoughAllowance === false && hasValidPendingPermit !== true
   const withWarning =
     (hasEnoughBalance === false || withAllowanceWarning) &&
     // show the warning only for pending and scheduled orders
@@ -401,7 +401,7 @@ export function OrderRow({
 function usePricesDifference(
   prices: OrderRowProps['prices'],
   spotPrice: OrderRowProps['spotPrice'],
-  isInverted: boolean
+  isInverted: boolean,
 ): PriceDifference {
   const { estimatedExecutionPrice } = prices || {}
 
@@ -415,13 +415,13 @@ function usePricesDifference(
  */
 function useFeeAmountDifference(
   { inputCurrencyAmount }: OrderRowProps['orderParams']['rateInfoParams'],
-  prices: OrderRowProps['prices']
+  prices: OrderRowProps['prices'],
 ): Percent | undefined {
   const { feeAmount } = prices || {}
 
   return useSafeMemo(
     () => calculatePercentageInRelationToReference({ value: feeAmount, reference: inputCurrencyAmount }),
-    [feeAmount, inputCurrencyAmount]
+    [feeAmount, inputCurrencyAmount],
   )
 }
 

diff --git a/apps/cowswap-frontend/src/modules/ordersTable/utils/getOrderParams.ts b/apps/cowswap-frontend/src/modules/ordersTable/utils/getOrderParams.ts
@@ -22,7 +22,7 @@ const PERCENTAGE_FOR_PARTIAL_FILLS = new Percent(5, 10000) // 0.05%
 export function getOrderParams(
   chainId: SupportedChainId,
   balancesAndAllowances: BalancesAndAllowances,
-  order: ParsedOrder
+  order: ParsedOrder,
 ): OrderParams {
   const sellAmount = CurrencyAmount.fromRawAmount(order.inputToken, order.sellAmount)
   const buyAmount = CurrencyAmount.fromRawAmount(order.outputToken, order.buyAmount)