build: fix i18n script usage with nx (#3303)

cowprotocol · Oct 31, 2023 · 358d9f2 · 358d9f2
1 parent fb24d41
commit 358d9f2
Show file tree

Hide file tree

Showing 8 changed files with 30 additions and 74 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -9,7 +9,7 @@ yarn install
 ## Generate locale files
 
 ```
-yarn i18n:extract
+yarn i18n
 ```
 
 ## Run the interface

diff --git a/apps/cowswap-frontend/lingui.config.ts b/apps/cowswap-frontend/lingui.config.ts
diff --git a/apps/cowswap-frontend/package.json b/apps/cowswap-frontend/package.json
@@ -8,11 +8,6 @@
     "ipfs:build": "cross-env PUBLIC_URL=\".\" yarn build",
     "ipfs:publish": "npx ipfs-deploy build -p pinata -O",
     "patch-package": "npx patch-package",
-    "i18n": "yarn run i18n:compile",
-    "i18n:compile": "yarn run i18n:extract && npx lingui compile",
-    "i18n:extract": "cross-env NODE_ENV=development npx lingui extract --locale en-US",
-    "i18n:pseudo": "npx lingui extract --locale pseudo && lingui compile",
-    "postinstall": "yarn run i18n",
     "cosmos:clear": "rm -rf ./public/cosmos",
     "cosmos:run": "yarn run _cosmos:run",
     "build:cosmos": "cross-env NODE_ENV=development npx cosmos-export",

diff --git a/apps/cowswap-frontend/project.json b/apps/cowswap-frontend/project.json
@@ -8,6 +8,7 @@
       "executor": "@nx/vite:build",
       "outputs": ["{options.outputPath}"],
       "defaultConfiguration": "production",
+      "dependsOn": ["i18n:compile"],
       "options": {
         "outputPath": "build/cowswap"
       },
@@ -71,6 +72,28 @@
       "options": {
         "buildTarget": "cowswap-frontend:build"
       }
+    },
+
+    "i18n": {
+      "executor": "nx:noop",
+      "dependsOn": ["i18n:compile"]
+    },
+    "i18n:compile": {
+      "executor": "nx:run-commands",
+      "dependsOn": ["i18n:extract"],
+      "options": {
+        "command": "npx lingui compile"
+      },
+      "inputs": ["{projectRoot}/src/locales/*.po"],
+      "outputs": ["{projectRoot}/src/locales/*.js"]
+    },
+    "i18n:extract": {
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "cross-env NODE_ENV=development npx lingui extract --locale en-US"
+      },
+      "inputs": ["{workspaceRoot}/apps/**/*.{ts,tsx,jsx}", "{workspaceRoot}/libs/**/*.{ts,tsx,jsx}"],
+      "outputs": ["{projectRoot}/src/locales/*.po"]
     }
   },
   "tags": []

diff --git a/apps/cowswap-frontend/src/locales/README.md b/apps/cowswap-frontend/src/locales/README.md
diff --git a/libs/common-utils/src/environments.test.ts b/libs/common-utils/src/environments.test.ts
@@ -20,7 +20,7 @@ describe('Detect environments using host and path', () => {
     })
   })
 
-  describe('Is production', () => {
+  describe.only('Is production', () => {
     const isProduction = { ...DEFAULT_ENVIRONMENTS_CHECKS, isProd: true }
 
     it('swap.cow.fi', () => {

diff --git a/lingui.config.ts b/lingui.config.ts
@@ -1,8 +1,8 @@
 const linguiConfig = {
   catalogs: [
     {
-      path: '<rootDir>/src/locales/{locale}',
-      include: ['<rootDir>/src'],
+      path: '<rootDir>/apps/cowswap-frontend/src/locales/{locale}',
+      include: ['<rootDir>/apps', '<rootDir>/libs'],
     },
   ],
   fallbackLocales: {

diff --git a/package.json b/package.json
@@ -21,14 +21,15 @@
     "ci:build": "yarn run build:cowswap && yarn run build-widget",
     "ipfs:build": "PUBLIC_URL=\".\" yarn build",
     "ipfs:publish": "npx ipfs-deploy build -p pinata -O",
+    "i18n": "nx run-many -t i18n",
     "preview": "cross-env NODE_OPTIONS=--max-old-space-size=32768 nx run cowswap-frontend:preview",
     "test": "yarn test:all",
     "test:all": "nx run-many -t test",
     "e2e": "nx run-many -t e2e",
     "lint": "nx run-many -t lint",
-    "prebuild-app": "nx run cowswap-frontend:i18n",
+    "prebuild-app": "yarn i18n",
     "prepare": "husky install",
-    "postinstall": "yarn run patch-package",
+    "postinstall": "yarn run patch-package && yarn i18n",
     "analyze-build": "cross-env ANALYZE_BUNDLE=true ANALYZE_BUNDLE_TEMPLATE=sunburst yarn build"
   },
   "browser": {