-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Grandpa Contract Test to work with SDK v0.50 #4959
Update Grandpa Contract Test to work with SDK v0.50 #4959
Conversation
@@ -107,6 +107,9 @@ include contrib/devtools/Makefile | |||
|
|||
BUILD_TARGETS := build install | |||
|
|||
tidy-all: | |||
./scripts/go-mod-tidy-all.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included this from main to reduce headaches when messing with multiple go mods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot woot!! 🚀 Superb work my friend!! All looks fantastic to me. I left some notes/suggestions, but mostly just commented on things that might have gotten overlooked after all the debugging. Happy with how it is now :)
…b.com/cosmos/ibc-go into cian/issue#4800-refactor-grandpa-test
Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible! Thank you.
func (s *E2ETestSuite) SetupChainsRelayerAndChannel(ctx context.Context, channelOpts ...func(*ibc.CreateChannelOptions)) (ibc.Relayer, ibc.ChannelOutput) { | ||
chainA, chainB := s.GetChains() | ||
func (s *E2ETestSuite) SetupChainsRelayerAndChannel(ctx context.Context, channelOpts func(*ibc.CreateChannelOptions), chainSpecOpts ...ChainOptionConfiguration) (ibc.Relayer, ibc.ChannelOutput) { | ||
chainA, chainB := s.GetChains(chainSpecOpts...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could add this as a new function, something like SetupChainsRelayerAndChannelWithChainSpecs
, which would help reduce the diffs in the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern there is that we don't really need an additional function (yet!), since we either configure everything, or we do just the chains like in the new test that's being added.
I'm hoping the diff wasn't too bad 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's alright. Makes sense!
I'm going to merge this PR, I'm seeing that there is one test failure that is using the regular simd (not the wasm image). I plan on syncing the feature branch with main and then re-running that test. I will dig into it further if it fails again then! |
Description
closes: #4800
E2E test run here - the test failures are actually using images from
main
and are should not be relevant for this PR. If these are still failing after we sync with main, I will look into them.The scope of work for this issue grew over time as additional bugs popped up. The following changes were needed to support sdk 50 with the test.
relayer.New
fn.SetupChainsRelayerAndChannel
into sub functions to enable more granular control in tests. e.g. the connection and channel handshakes themselves are under test.cosmos.CosmosChain
toibc.Chain
, this is to allow other implementations to be subbed in. (used only in this test suite.)MsgStoreCode
is the largest message used in the tests so far, and required this increase (shout out to @colin-axner for the suggestion ❤️ )DefaultGasValue
needed to be bumped, the existing value was not enough for the test.I created this issue on the SDK to cover the CLI errors that I ran into. The current code does not make use of
simd q
for gov proposals as it fails when there is an embeddedAny
.Next Steps:
stake
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.