Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in FullDetectorResponse #280

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

ckarwin
Copy link
Contributor

@ckarwin ckarwin commented Jan 9, 2025

There is a small bug in FullDetectorResponse. When the code defines the labels for a response file without polarization, it still includes a polarization label. This causes a mismatch between the labels and edges, which throws and error. I caught this when testing the spectral fit for DC3 511 response. Removing the "Pol" label fixed the problem.

@ckarwin ckarwin added the bug Something isn't working label Jan 9, 2025
@GallegoSav
Copy link
Contributor

@israelmcmc Maybe you can bypass the unit test giving the small change in the code ?

@ckarwin
Copy link
Contributor Author

ckarwin commented Jan 10, 2025

Thanks, @GallegoSav. @israelmcmc Do you know what the error is with the unit test? It seems to be some other issue.

@israelmcmc
Copy link
Collaborator

It's an issue with the test coverage check:

error - 2025-01-09 20:19:58,394 -- Report creating failed: {"message":"Token required because branch is protected"}
Error: Codecov:
                        Failed to properly create report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

It doesn't seem to be a problem related to this change though. I'll close and reopen this PR to give it a kick.

@israelmcmc israelmcmc closed this Jan 10, 2025
@israelmcmc israelmcmc reopened this Jan 10, 2025
@israelmcmc
Copy link
Collaborator

That fixed it. It seems it was only a glitch. I'll merge this. Thanks @ckarwin for the fix and @GallegoSav for reviewing.

@israelmcmc israelmcmc merged commit aea580b into cositools:develop Jan 10, 2025
3 of 4 checks passed
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (e9bf11e) to head (7e392d0).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
cosipy/response/FullDetectorResponse.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
cosipy/response/FullDetectorResponse.py 39.29% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants