solve issue 236 #253
solve issue 236 #253
Conversation
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
@GallegoSav Thanks for taking care of this. The changes look good, and the logic makes sense. I added a few minor comments to clean up the code before merging. I'll check again when you make the updates.
cosipy/data_io/UnBinnedData.py
Outdated
| @@ -185,6 +185,16 @@ def read_tra(self, output_name=None, run_test=False, use_ori=False, | |||
| if len(this_line) == 0: | |||
| continue | |||
|
|
|||
There was a problem hiding this comment.
Please remove empty white space (lines 188 and 189 )
cosipy/data_io/UnBinnedData.py
Outdated
|
|
||
| # Event type: | ||
| if this_line[0] == "ET": | ||
| #Check we are looking CO evt |
There was a problem hiding this comment.
#Check we are looking CO evt --> # Check that we are looking at CO events
cosipy/data_io/UnBinnedData.py
Outdated
| # Event type: | ||
| if this_line[0] == "ET": | ||
| #Check we are looking CO evt | ||
| if this_line[1] == "CO" : |
There was a problem hiding this comment.
Remove space before colon.
cosipy/data_io/UnBinnedData.py
Outdated
| #Check we are looking CO evt | ||
| if this_line[1] == "CO" : | ||
| et.append(this_line[1]) | ||
| else : |
There was a problem hiding this comment.
Remove space before colon.
cosipy/data_io/UnBinnedData.py
Outdated
| # Event type: | ||
| if this_line[0] == "ET": | ||
| et.append(this_line[1]) | ||
|
|
||
|
|
There was a problem hiding this comment.
Remove empty space (line 232)
No description provided.