Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change print() to logging.info() #233

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

krishnatejavedula
Copy link
Contributor

Replaced print statements with logging in various files to improve logging consistency, clarity, and debugging capabilities.
Updated logging statements in the following files:

cosipy/ts_map/fast_ts_fit.py
cosipy/ts_map/TSMap.py
cosipy/response/FullDetectorResponse.py
cosipy/spacecraftfile/SpacecraftFile.py

Addresses issue #48

…gging consistency, clarity, and debugging capabilities. Updated logging statements in the following files:

cosipy/ts_map/fast_ts_fit.py
cosipy/ts_map/TSMap.py
cosipy/response/FullDetectorResponse.py
cosipy/spacecraftfile/SpacecraftFile.py
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 63.18%. Comparing base (d74b7cf) to head (08e56ce).

Files Patch % Lines
cosipy/response/FullDetectorResponse.py 6.25% 15 Missing ⚠️
cosipy/ts_map/TSMap.py 33.33% 4 Missing ⚠️
cosipy/ts_map/fast_ts_fit.py 66.66% 2 Missing ⚠️
Files Coverage Δ
cosipy/spacecraftfile/SpacecraftFile.py 25.62% <ø> (ø)
cosipy/ts_map/fast_ts_fit.py 54.23% <66.66%> (+0.52%) ⬆️
cosipy/ts_map/TSMap.py 23.58% <33.33%> (+1.46%) ⬆️
cosipy/response/FullDetectorResponse.py 38.75% <6.25%> (ø)

Copy link
Collaborator

@israelmcmc israelmcmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krishnatejavedula. I can merge it after we address the small change I suggested. I'll waive the patch coverage threshold requirement since this code is not adding new functionality.

cosipy/response/FullDetectorResponse.py Outdated Show resolved Hide resolved
@israelmcmc
Copy link
Collaborator

Thanks @krishnatejavedula! I'm merging this

@israelmcmc israelmcmc merged commit 607d417 into cositools:develop Aug 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants