Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the point source response content to the DetectorResponse notebook #150

Closed
wants to merge 10 commits into from

Conversation

Yong2Sheng
Copy link
Contributor

@Yong2Sheng Yong2Sheng commented Feb 29, 2024

Caution: This is a draft PR. I opened it because @israelmcmc will work on his part based on this PR.

My changes for this PR are:

Changed file(s):

  1. DetectorResponse.ipynb

    • I removed the hard-coded part of the point source response. It's replaced by the method with the SpacecraftFile module.
    • To view the added contents, please go to the Point source response section in the notebook
  2. Point_source_response.ipynb

    • Updated the method for get_dwell_map to accelerate the calculation
    • In general, I use the Hadamard product of matrices to replace the for-loop over the time intervals
    • Using the old get_ts_map, it needs 153 minutes to calculate the dwell time map for Crab over the full 3-month orientation
    • Using the new get_ts_map, it only need 9.58s to do the same calculation.
  3. SpacecraftFile.py, scatt_map.py, TSMap.py, fast_ts_fit.py

    • Added or updated the doc string.

Added file(s):

  1. Crab_DwellMap.fits
    • This is the dwell time map for Crab over the 3-month orientation.

Deleted files(s)

  1. Cygx1_balloon_dtpoins_remove_none.npy
  2. Cygx1_balloon_timestamp_random_remove_none.npy
  3. Cygx1_balloon_xpoins_remove_none.npy
  4. Cygx1_balloon_ypoins_remove_none.npy
  5. Cygx1_balloon_zpoins_remove_none.npy

@ckarwin ckarwin marked this pull request as draft March 4, 2024 15:51
@ckarwin
Copy link
Contributor

ckarwin commented Mar 4, 2024

Hi @Yong2Sheng I converted your PR to a draft, based on your cation message.

@Yong2Sheng
Copy link
Contributor Author

Thank you @ckarwin! I didn't know PR has a draft mode haha.

…the same, so it will be effective for other codes that used the old one.
@ckarwin ckarwin linked an issue Mar 5, 2024 that may be closed by this pull request
@israelmcmc
Copy link
Collaborator

@Yong2Sheng I'm cleaning up issues and PRs, so I'm closing this one since all your commits and changes are now in #149 (as we discussed). If I missed anything, please feel free to reopen it and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No doc strings in cosipy.ts_map.TSMap
3 participants