-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the point source response content to the DetectorResponse notebook #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; Added the ori file for CgyX1; Deleted the npy files for CygX1 (they are replaced by the new .ori file)
Hi @Yong2Sheng I converted your PR to a draft, based on your cation message. |
Thank you @ckarwin! I didn't know PR has a draft mode haha. |
…the same, so it will be effective for other codes that used the old one.
This was referenced Mar 13, 2024
@Yong2Sheng I'm cleaning up issues and PRs, so I'm closing this one since all your commits and changes are now in #149 (as we discussed). If I missed anything, please feel free to reopen it and let me know. |
This was referenced Mar 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution: This is a draft PR. I opened it because @israelmcmc will work on his part based on this PR.
My changes for this PR are:
Changed file(s):
DetectorResponse.ipynb
SpacecraftFile
module.Point source response
section in the notebookPoint_source_response.ipynb
get_dwell_map
to accelerate the calculationget_ts_map
, it needs 153 minutes to calculate the dwell time map for Crab over the full 3-month orientationget_ts_map
, it only need 9.58s to do the same calculation.SpacecraftFile.py, scatt_map.py, TSMap.py, fast_ts_fit.py
Added file(s):
Deleted files(s)
Cygx1_balloon_dtpoins_remove_none.npy
Cygx1_balloon_timestamp_random_remove_none.npy
Cygx1_balloon_xpoins_remove_none.npy
Cygx1_balloon_ypoins_remove_none.npy
Cygx1_balloon_zpoins_remove_none.npy