-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cells to download files in grb & crab spectral fit notebooks #144
Conversation
Hi @eneights, Thanks for making these changes. I reviewed your PR, and all the new cells are working. There are still some small details that I think need to be updated though, specified below. Also, it looks like the line fit example has not been updated yet. Were you planning to do this as well? Both Crab and GRB notebooks:
Most users won't have access to wasabi, and so I think you can just say that the files need to be downloaded using the first few cells of the notebook.
|
Thanks @ckarwin! I made those changes. The point source line fitting notebook should probably be deleted, do you want me to do that? It's for the Compton sphere and the extended source 511 notebook replaces it. |
Thanks for making the changes, @eneights. Ok, I see. I think it's probably ok to remove the line fitting notebook. Let's double check with @israelmcmc, do you see any problems with this? |
I also agree it's good to remove it. Conceptually, the jump from a PL or band function to a Dirac delta (or a narrow Gaussian) is not that big, so I think the users will not get lost if the line emission analysis is introduced together with the extended source emission ---which is the realistic use case anyways. The 511-emitting "GRB" had its purpose when were trying to figure out the implementation and it allowed us to tackle one problem at a time, but at this point, it's better to reduce the number of notebooks that we need to maintain. |
Ok, @eneights, please go ahead and remove the line fit NB, and then I can merge this PR. In the second line of the extended source NB it says:
Can you also delete:
|
@ckarwin I deleted the line fit tutorial and its references in the extended source notebook and other_examples.rst. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @eneights.
Add cells in the grb & crab spectral fitting notebooks to download the necessary files from wasabi