tmpfiles: Misc cleanup patches #5248
Merged
+176
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we kind of viewed the "translate tmpfiles in package import" as the core flow, but I think that needs to be a peer of "postprocess tmpfiles". Move all the tmpfiles code from importer.rs into tmpfiles.rs. No functional changes. Signed-off-by: Colin Walters <[email protected]>
Signed-off-by: Colin Walters <[email protected]>
- std - external crates - local crates Signed-off-by: Colin Walters <[email protected]>
I think this is clearer.
We were using `.ok()` which swallows errors, probably because correctly propagating Result through combinators is painful. A direct iterator here makes handling errors much easier.
For better test failure diagnosis.
This affects *global state* and is almost certainly the cause of coreos@9baf570
|
Pushed more cleanup here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just prep for more work.
Move more tmpfiles code into tmpfiles module
Before we kind of viewed the "translate tmpfiles in package import"
as the core flow, but I think that needs to be a peer of
"postprocess tmpfiles".
Move all the tmpfiles code from importer.rs into tmpfiles.rs.
No functional changes.
Signed-off-by: Colin Walters [email protected]
importer: Add a comment linking to the consumer side
Signed-off-by: Colin Walters [email protected]
tmpfiles: Canonicalize import order
Signed-off-by: Colin Walters [email protected]
tmpfiles: Rename escape function
I think this is clearer.