Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-2058: Add Corda container logging configuration #77

Merged
merged 1 commit into from
Mar 15, 2024
Merged

ES-2058: Add Corda container logging configuration #77

merged 1 commit into from
Mar 15, 2024

Conversation

anton-subbotin
Copy link
Contributor

@anton-subbotin anton-subbotin commented Mar 15, 2024 •
edited
Loading

  • logs go to both console and files
  • console logs are available via docker logs
  • file logs are at the same location used by CSDE template
  • default configurations of logging level and debug logging are provided explicitly, allowing users to modify as needed

All of the above tested locally.

image

@anton-subbotin anton-subbotin marked this pull request as ready for review March 15, 2024 09:35
tlawson3
tlawson3 reviewed Mar 15, 2024
View reviewed changes
config/combined-worker-compose.yaml
environment:
JAVA_TOOL_OPTIONS: -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005
LOG4J_CONFIG_FILE: config/log4j2.xml
CONSOLE_LOG_LEVEL: info
ENABLE_LOG4J2_DEBUG: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is ENABLE_LOG4J2_DEBUG used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used in all worker containers: https://github.com/corda/corda-runtime-os/blob/aed62cd840068b090ad5a114fd7be5a40898350b/buildSrc/src/main/groovy/DeployableContainerBuilder.groovy#L273
And documented here: https://github.com/corda/corda-runtime-os/blob/aed62cd840068b090ad5a114fd7be5a40898350b/buildSrc/src/main/groovy/DeployableContainerBuilder.groovy#L273

@anton-subbotin anton-subbotin merged commit 2278f8d into release-V5.2 Mar 15, 2024
4 checks passed
@anton-subbotin anton-subbotin deleted the asubbotin/ES-2058/add-logging-config branch March 15, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlawson3 tlawson3 tlawson3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-subbotin @tlawson3