NGSTN-1241 Farster coldstart with HTTP/protobuf exporters #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhrebicek
approved these changes
Dec 4, 2024
RafalSumislawski
merged commit 6b730a6
into
coralogix-nodejs-autoinstrumentation
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OTLP http/proto instead of OTLP gRPC exporters. This way we avoid having to package (layer size) and initialise (invoke duraiton) gRPC librarary. http library is built-in and initialised anyway. We still pay the cost of the protobuf library.
This change also fixes a warning log about gRPC instrumentation. And it required suppressing HTTP instrumentation or else we would generate extra spans and metrics.