Disable callbackWaitsForEmptyEventLoop for promise based handlers #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtimush
approved these changes
Jul 11, 2024
RafalSumislawski
merged commit 0a29c0d
into
coralogix-nodejs-autoinstrumentation
1 of 3 checks passed
RafalSumislawski
deleted the
feature/CDS-1315-dont-wait-for-empty-eventloop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our handler is always callback based. We can't follow the handler type of the user's handler, becuase we don't know it (the only way we can learn it is by invoking the handler and seeing what it returns).
Unfortunately AWS's behaviour is different for Promise and callback based handlers. It waits for eventloop to be empty in case of callback based handlers (https://github.com/aws/aws-lambda-nodejs-runtime-interface-client/blob/main/src/CallbackContext.js#L46). This means that wrapping a promise based handler in our handler implicitly enables that feature, leading to unindended behaviour. To solve this problem we disable the feature when the handler is promise based.