Avoid issues with cyclic jsons when instrumentig S3 by replicating python's logic #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalSumislawski
requested review from
kolov,
rtimush,
zhrebicek,
v-tec2706 and
NimrodAvni78
zhrebicek
approved these changes
Jul 4, 2024
Base automatically changed from
nodejs-cx-wrapper
to
coralogix-nodejs-autoinstrumentation
July 4, 2024 13:47
…CDS-1339-avoid-s3-cyclic-jsons # Conflicts: # ci-scripts/build_nodejs_layer.sh # nodejs/packages/cx-wrapper/instrumentation-init.ts # nodejs/packages/cx-wrapper/package-lock.json # nodejs/packages/layer/package-lock.json
RafalSumislawski
merged commit 9c5a661
into
coralogix-nodejs-autoinstrumentation
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicates the logic of: https://github.com/coralogix/opentelemetry-python-contrib/blob/c88ac196a0093154f4e55001c0665e2701abd7f5/instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py#L391-L405
Depends on: #37