Feautre/cds 707 limit body attribute #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalSumislawski
requested review from
kolov,
rtimush,
zhrebicek,
povilasv,
NimrodAvni78 and
lukaszwojtowcoralogix
zhrebicek
reviewed
Oct 18, 2023
| @@ -201,6 +201,7 @@ const lambdaAutoInstrumentConfig: AwsLambdaInstrumentationConfig = { | |||
| } | |||
| return otelContext.active(); | |||
| }, | |||
| payloadSizeLimit: OTEL_PAYLOAD_SIZE_LIMIT, | |||
There was a problem hiding this comment.
Some context, about why this one liner helps would be nice, but approving anyway.
There was a problem hiding this comment.
This is a continuation of coralogix/opentelemetry-js-contrib#8
OTEL_PAYLOAD_SIZE_LIMIT is already used to limit some attributes that are produced by code located in opentelemetry-lambda. Now I also propagate it to the code of opentelemetry-js-contrib where the AwsLambdaInstrumetation is located. And there I use it to limit the size of an attribute that contains the response body (or now, the first 50kiB of the response body)
zhrebicek
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.