Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): add user settings support with
defaults
values and trusts #1940base: master
Are you sure you want to change the base?
feat(settings): add user settings support with
defaults
values and trusts #1940Changes from all commits
5e22a28
211835d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we should use
copier.vcs.get_repo()
to normalize trusted repository URLs to be more robust against non-canonical URLs. From the tests below, a (normalized) repositoryhttps://github.com/user/repo.git
wouldn't be considered trusted despite the trust list entryhttps://github.com/user/repo
. Won't this lead to confusion?I realize that
copier.vcs.get_repo()
currently doesn't handle URLs with a trailing slash properly:>>> get_repo("https://github.com/user/repo/") 'https://github.com/user/repo/.git'
But this could be fixed. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I noticed that when I started #1941. That's one of the reasons I separated the shortcuts into their own PR.
If this is OK for you, I would prefer handling
get_repo
and URL normalization in #1941 as it is its main point. It would allow having the full picture and craft a solution that handles more cases.I think we have the opportunity to properly review/complete/fix normalization rules in #1941. (I'll properly rebase it when this one is merged so we can have a clear view)