Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(lint): switch over to ruff; add taplo #1444

Merged
merged 2 commits into from
Jan 15, 2024
Merged

build(lint): switch over to ruff; add taplo #1444

merged 2 commits into from
Jan 15, 2024

Conversation

yajo
Copy link
Member

@yajo yajo commented Dec 1, 2023

Ruff is faster, better integrated, easier to configure... Cool!

Taplo also helps with toml maintenance.

@yajo yajo self-assigned this Dec 1, 2023
@yajo yajo added the maintenance Boring maintenance routine label Dec 1, 2023
@yajo yajo added this to the Soon milestone Dec 1, 2023
@yajo yajo requested a review from sisp December 1, 2023 10:06
@yajo yajo changed the title build(lint): switch over to ruff build(lint): switch over to ruff; add taplo Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53aab1f) 97.46% compared to head (5f0cb01) 97.46%.
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1444   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          48       48           
  Lines        4537     4537           
=======================================
  Hits         4422     4422           
  Misses        115      115           
Flag Coverage Δ
unittests 97.46% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisp
Copy link
Member

sisp commented Dec 1, 2023

There's some Nix error, but I still don't know enough about Nix to say what's wrong. 🫣

And I wonder whether the Ruff pre-commit hook also checks/applies formatting because the hook spec looks a bit outdated. With a recent Ruff version, it's ruff check for linting and ruff format for formatting. We'd want to make sure the formatting is also checked through CI. Do you know, @yajo?

pyproject.toml Outdated Show resolved Hide resolved
@pawamoy
Copy link
Contributor

pawamoy commented Dec 1, 2023

I see taplo in nix's configs, but nowhere else: what does it do? I guess it's used to format TOML files in VSCode? 🤔

@yajo yajo marked this pull request as draft December 5, 2023 06:29
@yajo yajo marked this pull request as ready for review January 15, 2024 17:57
@yajo
Copy link
Member Author

yajo commented Jan 15, 2024

Well, nix configs make the .pre-commit-config.yaml nix-generated file use taplo. It's just a TOML formatter.

You have a brief explanation of how it works here.

Ruff is faster, better integrated, easier to configure... Cool!

Taplo also helps with toml maintenance.
Upstream issue is solved now.
@yajo yajo enabled auto-merge (rebase) January 15, 2024 18:02
@yajo yajo disabled auto-merge January 15, 2024 18:26
@yajo yajo merged commit 1395040 into master Jan 15, 2024
21 checks passed
@yajo yajo deleted the ruff branch January 15, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring maintenance routine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants