Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain how to use computed variables, more clearly #1420

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

yajo
Copy link
Member

@yajo yajo commented Nov 20, 2023

Fixes #1414 by documenting a clearer and safe alternative that covers most cases.

Fixes #1414 by documenting a clearer and safe alternative that covers most cases.
@yajo yajo enabled auto-merge November 20, 2023 20:53
@yajo yajo disabled auto-merge November 20, 2023 20:53
@yajo yajo enabled auto-merge (rebase) November 20, 2023 20:53
@yajo yajo self-assigned this Nov 20, 2023
@yajo yajo added the documentation Issue that requires updating docs label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (007f830) 97.46% compared to head (ebbb5ad) 97.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          48       48           
  Lines        4462     4462           
=======================================
  Hits         4349     4349           
  Misses        113      113           
Flag Coverage Δ
unittests 97.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yajo yajo requested review from pawamoy and a team and removed request for pawamoy November 21, 2023 15:49
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

@yajo yajo merged commit 50d478e into master Nov 21, 2023
20 checks passed
@yajo yajo deleted the computed-docs branch November 21, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue that requires updating docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make the context-hook extension a "safe" extension
2 participants