fix: Address deprecation warning in shutil.rmtree(onerror=...)
#1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
changed the title
rmtree(onerror=...)shutil.rmtree(onerror=...)
edgarrmondragon
force-pushed
the
fix/rmtree-onerror-deprecation-warning
branch
2 times, most recently
from
280c5e2 to
97e136d
Compare
edgarrmondragon
force-pushed
the
fix/rmtree-onerror-deprecation-warning
branch
from
97e136d to
ba65802
Compare
Codecov Report
@@ Coverage Diff @@
## master #1401 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 48 48
Lines 4423 4426 +3
=======================================
+ Hits 4310 4313 +3
Misses 113 113
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sisp
approved these changes
Nov 11, 2023
There was a problem hiding this comment.
Thanks for catching this warning and submitting a PR, @edgarrmondragon! 🙏
LGTM! 🎉 Very similar to, e.g., pytest-dev/pytest#10893. 👍
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1402