-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add justfile for use with docker #5621
Add justfile for use with docker #5621
Conversation
I like This pull-request seems good enough for development, however, it should be clear that expanding its use to production can in some cases lead to strange behaviors in signal management between just and the application that is executed with the help of just |
Thanks for the quick reply. I wasn't aware of the bug. I intended this for local development hence it is using the local compose file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, would be a nice addition.
Could you please add a paragraph about it in the documentation about local Docker development (under tips & tricks) or -even better- update all docker compose ...
commands to their justfile equivalent?
@browniebroke I have added the relevant docs too. Let me know if there is anything missing. Thanks. |
That looks good from my perspective @luzfcb it's documented as being for local development in our docs. Are you hapy with that or do you think we should make the limitations more prominent in the file itself? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the Zen of Python that says that Explicit is better than implicit
, I would find it useful to include a warning about this and thus perhaps help prevent our users from losing hours of debugging due to a specific behavior of the current version of Just.
I myself spent a lot of time in the past debugging this and not understanding what was wrong.
Co-authored-by: Fábio C. Barrionuevo da Luz <[email protected]>
Co-authored-by: Fábio C. Barrionuevo da Luz <[email protected]>
for more information, see https://pre-commit.ci
Thank you for the contribution 🎉 |
Description
Set up just to simplify calling docker commands.
Checklist:
Rationale
It helps to run frequent commands quicker. This PR attempted to do this via MakeFile. However, using
just
seems like a better approach, especially since it is a cross-platform tool (can be installed via pip), as mentioned in this comment as well.Closes #1879
Fix #3318