Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rendering streamed audio and spotify tracks. #3576

Merged
merged 6 commits into from
Jan 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Github Issues
- #122: Set horizontal layout direction based on the language
- #317: Add the ability to render audio streams. New config option [fetch_url_headers](https://conversejs.org/docs/html/configuration.html#fetch-url-headers)
- #698: Add support for MUC private messages
- #1021: Message from non-roster contacts don't appear in fullscreen view_mode
- #1038: Support setting node config manually
Expand All @@ -19,9 +20,8 @@
- #2980: Allow setting an avatar for MUCs
- #3033: Add the `muc_grouped_by_domain` option to display MUCs on the same domain in collapsible groups
- #3038: Message to self from other client is ignored
- #3038: Support showing yourself in the MUC sidebar. Adds new config option `muc_show_self`.
- #3038: Support showing yourself in the left sidebar. Adds new config option `[show_self_in_roster](https://conversejs.org/docs/html/configuration.html#show-self-in-roster)`.
- #3100: fixed width `.box-flyout` breaks responsive design in embedded, mobile viewport mode.
- #3038: Support showing yourself in the MUC sidebar. Adds new config option `muc_show_self`.
- #3155: Some ad-hoc commands not working
- #3155: Some adhoc commands aren't working
- #3299: Registration fails when a password contains an &
Expand Down Expand Up @@ -49,6 +49,7 @@
- Fix: renaming getEmojisByAtrribute to getEmojisByAttribute.

### Changes and features
- Embed the Spotify player for links to Spotify tracks. New config option [embed_3rd_party_media_players](https://conversejs.org/docs/html/configuration.html#embed-3rd-party-media-players).
- Add support for XEP-0191 Blocking Command
- Upgrade to Bootstrap 5
- Add an occupants filter to the MUC sidebar
Expand Down
16 changes: 16 additions & 0 deletions docs/source/configuration.rst
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,14 @@ domain_placeholder

The placeholder text shown in the domain input on the registration form.

embed_3rd_party_media_players
-----------------------------

* Default: ``true``

If ``true``, links to 3rd party media sites, such as Spotify will be turned
into embedded media players from those sites (if supported by Converse).


emoji_categories
----------------
Expand Down Expand Up @@ -917,6 +925,14 @@ support is turned on or not.
Recommended to set to ``true`` if a websocket connection is used.
Please see the :ref:`websocket-url` configuration setting.

fetch_url_headers
-----------------

* Default: ``true``

If set to ``false``, then Converse won't fetch the headers of URLs to determine
whether they link to media that can be embedded (e.g. streaming audio).

filter_by_resource
------------------

Expand Down
1 change: 1 addition & 0 deletions src/headless/shared/settings/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export const DEFAULT_SETTINGS = {
credentials_url: null, // URL from where login credentials can be fetched
disable_effects: false, // Disabled UI transition effects. Mainly used for tests.
discover_connection_methods: true,
embed_3rd_party_media_players: true,
geouri_regex: /https\:\/\/www.openstreetmap.org\/.*#map=[0-9]+\/([\-0-9.]+)\/([\-0-9.]+)\S*/g,
geouri_replacement: 'https://www.openstreetmap.org/?mlat=$1&mlon=$2#map=18/$1/$2',
i18n: undefined,
Expand Down
21 changes: 0 additions & 21 deletions src/headless/types/plugins/blocking/collection.d.ts

This file was deleted.

2 changes: 0 additions & 2 deletions src/headless/types/plugins/blocking/index.d.ts

This file was deleted.

6 changes: 0 additions & 6 deletions src/headless/types/plugins/blocking/model.d.ts

This file was deleted.

2 changes: 0 additions & 2 deletions src/headless/types/plugins/blocking/plugin.d.ts

This file was deleted.

4 changes: 0 additions & 4 deletions src/headless/types/plugins/pubsub.d.ts

This file was deleted.

1 change: 1 addition & 0 deletions src/headless/types/shared/settings/constants.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export namespace DEFAULT_SETTINGS {
let credentials_url: any;
let disable_effects: boolean;
let discover_connection_methods: boolean;
let embed_3rd_party_media_players: boolean;
let geouri_regex: RegExp;
let geouri_replacement: string;
let i18n: any;
Expand Down
1 change: 1 addition & 0 deletions src/plugins/chatview/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ converse.plugins.add('converse-chatview', {
* loaded by converse.js's plugin machinery.
*/
api.settings.extend({
'fetch_url_headers': true,
'allowed_audio_domains': null,
'allowed_image_domains': null,
'allowed_video_domains': null,
Expand Down
Loading
Loading