Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3439: form field regression. #3443

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix #3439: form field regression. #3443

merged 1 commit into from
Jul 19, 2024

Conversation

JohnXLivingston
Copy link
Contributor

Trying to fix #3439

I am absolutly not sure that this fix is correct. I only tried to guess what you meant to write.

@JohnXLivingston JohnXLivingston requested a review from jcbrand July 11, 2024 16:37
@jcbrand jcbrand merged commit 75848e3 into master Jul 19, 2024
4 checks passed
@jcbrand jcbrand deleted the fix_3439 branch July 19, 2024 07:09
@jcbrand
Copy link
Member

jcbrand commented Jul 19, 2024

I think what you did makes sense, thanks.

@JohnXLivingston
Copy link
Contributor Author

For the record, the type definition for XFormFieldTypes is still missing some possible values. For example number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcbrand jcbrand Awaiting requested review from jcbrand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form regression for number fields
2 participants
@JohnXLivingston @jcbrand