-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bootstrap 5 #3437
Merged
Merged
Upgrade to Bootstrap 5 #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbrand
force-pushed
the
jcbrand/bootstrap5
branch
from
July 10, 2024 07:23
c777ddb
to
df1e5e4
Compare
jcbrand
force-pushed
the
jcbrand/bootstrap5
branch
5 times, most recently
from
July 25, 2024 08:12
bebcdfc
to
4532c28
Compare
jcbrand
force-pushed
the
jcbrand/bootstrap5
branch
14 times, most recently
from
July 31, 2024 07:23
9c5787f
to
e5edeec
Compare
- Remove unused form classes - Add `form-label` class - Set custom bootstrap prefix (to `converse-`) - Re-style the minimized chats toggle - Remove old CSS and use Boostrap markup. - Re-style the controlbox toggle - Use bootstrap grid classes for chat boxes and controlbox toggle. - Remove unused css from core - Use bootstrap for dropdown/modal/popover instead of bootstrap.native - Namespace bootstrap files - Fix closing of confirm alert
- Make chat head buttons a `btn-toolbar` - Make the chat toolbar a `btn-toolbar`
Looks like this also fixes #3413
- Use Bootstrap columns to. - Make the sidebar full size one small viewports.
Also fixes wrong padding for the chat textarea.
Make the fonts smaller and tighten up padding.
- Unfurl and card styling fixes - Better color choices for the `dracula` theme - Fix dropdown icons color in MUC sidebar
- Remove the `.controlbox-head` element. - Remove the `.controlbox-panes` element. - Remove unused CSS styles. - Create a new component for rendering the controlbox buttons. - Move styles to loginform.scss
Fix rendering of skintone picker.
Until it can be properly implemented again.
jcbrand
force-pushed
the
jcbrand/bootstrap5
branch
from
August 1, 2024 07:12
e5edeec
to
80b3a91
Compare
I am very much looking forward to the next release! Tiki Wiki CMS groupware bundles Converse.js and is already in Bootstrap 5 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making a pull request to converse.js!
Before submitting your request, please make sure the following conditions are met:
CHANGES.md
document it in
docs/source/configuration.rst
with
make check
or you can run them in the browser by runningmake serve
and then opening
http://localhost:8000/tests.html
.